Repository navigation
fix: explain rejected review commands without retry or comment spam - #21
Merged
Merged
Conversation
This was referenced Nov 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authorized review commands that hit a policy limit currently disappear: all admission denials become HTTP 429, webhook recovery retries them, and no public explanation is recorded. This change persists the exact admission outcome and safely publishes an App-owned PR issue comment without dispatching inference.
0005_review_admission_feedback.sqlfor a tenant-scoped feedback outbox. Original command IDs and leases deduplicate parallel workers, webhook redelivery and cron. Accepted-command redeliveries reuse the existing request rather than spend another rerun or claim a false denial.Validation: full check/typecheck/lint/build, direct quota/time/concurrency/failure regression tests, clean-checkout npm ci/check, actual workerd/D1 atomic admission and migrations, Chromium onboarding, catalog verification, Actionlint, npm audit, Docker/native Codex synthetic-provider sandbox, High/Critical image scan and Worker dry-run. The D1 test caught the runtime compound-SELECT limit; the final query uses VALUES and passes workerd.
Production rollout, explicitly authorized by the operator: wait for required CI/protections; squash merge; derive the actual merge SHA with the existing pin-upgrade script; review/merge Worker-test and caller pin PRs; apply pending migration 0005; deploy the reviewed Worker with browser OAuth, hosted web inference and automatic merging still disabled. Verify the deployed version and pins, health, a fresh exhausted-rerun command, terminal outbox/delivery state and no new inference workflow. Ordinary live inference smoke is excluded at the operator's request. No credentials, quota counters, active sessions, App permissions or branch protections are changed.